Time to change your phone?

I'm wondering when I should change my phone.

I usually have previous phones with very poor battery performance or

I tend to replace things when they break, so I use them for at least 3-4 years.

But I'm also tempted by the phones coming out these days.

I was curious when everyone changes their phones.